[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 20:36:16 PDT 2022


pengfei added a comment.

Thanks @RKSimon



================
Comment at: clang/lib/Headers/immintrin.h:223
+#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      \
+    (defined(__AVX512VL__) && defined(__AVX512FP16__))
 #include <avx512vlfp16intrin.h>
----------------
RKSimon wrote:
> (style) - other uses in this header put the defined(__AVX512VL__) after:
> ```
> (defined(__AVX512FP16__) && defined(__AVX512VL__))
> ```
This was copy+paste from AVX512BF16. Just have a look, puting it ahead seems a little more that the other. So let leave it as is :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132342/new/

https://reviews.llvm.org/D132342



More information about the cfe-commits mailing list