[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

Peter Klausler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 16:27:07 PDT 2022


klausler added a comment.

I can't speak to the lowering or driver bits, but the runtime part looks pretty good to me.



================
Comment at: flang/runtime/environment-default-list.h:1
+//===-- Runtime/environment-default-list.h --------------------------------===//
+//
----------------
If you want this header to be maximally portable C and C++, please observe the usage of other such headers, and use old-school C /*comments*/.

You could probably just use an 'int' for the item count and avoid some difficulty below, unless you expect a program to use billions of default environment settings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130513/new/

https://reviews.llvm.org/D130513



More information about the cfe-commits mailing list