[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 07:40:00 PDT 2022


dongjunduo marked 2 inline comments as done.
dongjunduo added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4667
+  // Whether `-ftime-trace` or `-ftime-trace=<path>` are specified
+  if (!TimeTrace && !TimeTraceFile) return;
+
----------------
jamieschmeiser wrote:
> The return should be on the next line.  Did you run this through clang-format?  Is it okay with this on the same line?
Yeah. I always use 'clang-format -i xxx.cpp' to check the code style, but some old codes may be restyled to a new format which I haven't modified. 

So I restore the code but forget to check the new added code then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469



More information about the cfe-commits mailing list