[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

[dongjunduo via Phabricator via cfe-commits]

dongjunduo marked 7 inline comments as done.
dongjunduo added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4674
+    for (auto &J : C.getJobs()) {
+      if (J.getSource().getKind() == Action::LinkJobClass &&
+          !J.getOutputFilenames().empty()) {
----------------
jamieschmeiser wrote:
> Can you have a link job without an output filename?  If not, then just have an assert for !empty.  Again, the negative test and continue might be easier to understand.
The output filename should not be empty. 

If the "-o" is not specified, the output filename may be "a.out".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469