[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

Alecto Irene Perez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 21 17:25:20 PDT 2022


alecto added a comment.

In D132256#3736076 <https://reviews.llvm.org/D132256#3736076>, @HazardyKnusperkeks wrote:

> Do we want to define the behavior of `MaxEmptyLinesToKeep < DefinitionBlockSpacing`? Then we need tests for that!
> Tests with `MaxEmptyLinesToKeep < DefinitionBlockSpacing` and initially more than `DefinitionBlockSpacing` should definitely be there.

Hello! To clarify, do you mean there should be unit tests for this behavior, or do you mean that there should be checks in clang-format itself that will alert the user if MaxEmptyLinesToKeep < DefinitionBlockSpacing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132256/new/

https://reviews.llvm.org/D132256



More information about the cfe-commits mailing list