[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a subscriber: ldionne.
erichkeane added a comment.

In D126907#3737986 <https://reviews.llvm.org/D126907#3737986>, @Mordante wrote:

> In D126907#3737641 <https://reviews.llvm.org/D126907#3737641>, @erichkeane wrote:
>
>> In D126907#3737375 <https://reviews.llvm.org/D126907#3737375>, @Mordante wrote:
>>
>>> This change breaks libc++'s modular build see build https://buildkite.com/llvm-project/libcxx-ci/builds/12991
>>> Reverting this commit on top of yesterday's build (before your revert) fixes the issue.
>>>
>>> libc++'s modular build uses Clang's pre-C++20 modules.
>>>
>>> It can be reproduced building libc++ and running the following lit invocation
>>> `${LIT} -Denable_modules=True libcxx/test/libcxx/ranges/range.adaptors/range.all/all.nodiscard.verify.cpp`
>>>
>>> If you need assistance testing a new version of this patch on libc++ please let me know.
>>
>> Is this not part of check-runtimes or check-cxx?  I ran both of those INCLUDING a modules-builds-all...
>
> It should be tested in `check-cxx` when you use the cmake option `-DLIBCXX_TEST_PARAMS="enable_modules=True"` and you need to configure libc++ to use your just build clang to be used for the tests. (The command I posted just does a single test, which is faster during bisecting.)
>
> I'm not sure what you mean with `modules-builds-all`.

There was a test I dealt with previously where a ton of the header files were run with modules enabled (and an auto generated files), so I'm shocked to find there is MORE differences here.  @ldionne : This is another example where trying to test libcxx is particularly difficult to do apparently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907