[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

weiyi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 14:07:12 PDT 2022


wyt added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:125
+    std::pair<std::string, DataflowAnalysisState<typename AnalysisT::Lattice>>>>
+getAnnotationStates(AnalysisData &AD) {
+  using StateT = DataflowAnalysisState<typename AnalysisT::Lattice>;
----------------
gribozavr2 wrote:
> Could we capture the lattice elements in the PostVisitCFG callback? It already receives the lattice element, we can easily copy it when the CFGElement is the Stmt of interest.
> 
> That should allow us to remove this function completely!
Coming in next patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132147/new/

https://reviews.llvm.org/D132147



More information about the cfe-commits mailing list