[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support
Paul Kirth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 19 14:00:35 PDT 2022
paulkirth added inline comments.
================
Comment at: lld/ELF/InputFiles.cpp:1721
+ Expected<MemoryBufferRef> fatLTOData = IRObjectFile::findBitcodeInMemBuffer(mb);
+ if (!errorToBool(fatLTOData.takeError()))
+ return make<BitcodeFile>(*fatLTOData, archiveName, offsetInArchive, /*lazy=*/false);
----------------
Do we just keep going if there's an error? This is only checking if there's **not** an error, right? or does `takeError` do more than I remember?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131618/new/
https://reviews.llvm.org/D131618
More information about the cfe-commits
mailing list