[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 12:33:48 PDT 2022


HazardyKnusperkeks added a comment.

In D132189#3733747 <https://reviews.llvm.org/D132189#3733747>, @rymiel wrote:

> There could also possibly be a TokenAnnotatorTest checking for `TT_FunctionAnnotationRParen`, but there wasn't an existing one similar to it, so I was unsure if I should add one

Always. :) In my opinion there are way too few annotator tests and one relies only on the formatting.



================
Comment at: clang/unittests/Format/FormatTest.cpp:9534
+               AlwaysBreak);
   verifyFormat("template <enum E> class A {\n"
                "public:\n"
----------------
Could you add a class with more than one character all upper case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132189/new/

https://reviews.llvm.org/D132189



More information about the cfe-commits mailing list