[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 08:56:56 PDT 2022


beanz added inline comments.


================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:103
+       << NumThreadsAttr->getZ();
+    OS.flush();
+    F->addFnAttr(NumThreadsKindStr, NumThreadsStr);
----------------
You can replace this whole chunk of code with:
```
std::string NumThreadsStr = llvm::formatv("{0},{1},{2}", NumThreadsAttr->getX(), NumThreadsAttr->getY(), NumThreadsAttr->getZ()).str();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131799/new/

https://reviews.llvm.org/D131799



More information about the cfe-commits mailing list