[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:791-793
+  /// TODO: Ellaborate why this is not a typed region, and why this is just an
+  /// 'approximation'.
+  QualType getApproximatedType() const {
----------------
I'm not sure how much explanation I need to do here, but first, we should settle on the name of this member function if we decide to have it.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:796-800
+    // FIXME: 1) Shouldn't this branch always taken due to the assertions in the
+    // ctor?
+    // FIXME: 2) Shouldn't we also handle if T is a block pointer?
+    if (T->isAnyPointerType() || T->isReferenceType())
+      T = T->getPointeeType();
----------------
I guess, these two questions together form the answer. The ctor only asserts that it is either a //any pointer//, //reference// *or* a //block pointer//. However, I'd like to get this confirmed. @NoQ 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132142/new/

https://reviews.llvm.org/D132142