[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 03:44:57 PDT 2022


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM, thanks @CarolineConcatto. Please land D132137 <https://reviews.llvm.org/D132137> before landing this one to avoid regressions on combines that previously worked on svget/svset.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9382
     SVETypeFlags TF(Builtin->TypeModifier);
     auto VTy = cast<llvm::VectorType>(getSVEType(TF));
+    Value *V0 = Builder.CreateExtractVector(VTy, Ops[0],
----------------
nit: If you cast this to `ScalableVectorType`, you can use `VTy->getMinNumElements()` below on line 9385


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131547/new/

https://reviews.llvm.org/D131547



More information about the cfe-commits mailing list