[PATCH] D128981: [C++20][Modules] Implement include translation.

Iain Sandoe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 01:33:06 PDT 2022


iains added a comment.

In D128981#3728503 <https://reviews.llvm.org/D128981#3728503>, @iains wrote:

> In D128981#3728070 <https://reviews.llvm.org/D128981#3728070>, @jansvoboda11 wrote:
>
>> Hi @iains, upstream Clang crashes on the attached test case due to an assertion failure. Git bisect pointed me to this commit. Can you please take a look? Previously, the test would result in a warning of incomplete umbrella header.
>
> yes, I can repeat this - will take a look.

I landed https://github.com/llvm/llvm-project/commit/a2dd6130d49777d63c2d1b641bd8e56f26fa0822 to fix this (assuming that there is no new fallout) - do you think we should back port to llvm-15?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128981/new/

https://reviews.llvm.org/D128981



More information about the cfe-commits mailing list