[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 22:46:02 PDT 2022


tbaeder added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:14938
+
+  if (E->getType().isNull())
+    return false;
----------------
shafik wrote:
> Curious why these two checks don't go w/ the `::Evaluate(Result, Info, E)` below.
No real reason I think, it's just that from looking at them, they seem to make sense to me in the general case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132136/new/

https://reviews.llvm.org/D132136



More information about the cfe-commits mailing list