[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

Matheus Izvekov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 16:55:12 PDT 2022


mizvekov added a comment.

In D128113#3733051 <https://reviews.llvm.org/D128113#3733051>, @joanahalili wrote:

> We have a translation unit, on which we see an increase of compilation time and clang memory allocation from 11GB to 14GB. We are working on an isolated case.

Thanks for looking into this!

What I can imagine may be happening here is that if we instantiate a template with a very large argument pack consisting of mostly the same template arguments, we will create many more `SubstTemplateTypeParmType` nodes with this patch, as they won't unique so much anymore, because each will have a different pack index.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128113/new/

https://reviews.llvm.org/D128113



More information about the cfe-commits mailing list