[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 07:04:08 PDT 2022


sammccall created this revision.
sammccall added a reviewer: ckandeler.
Herald added a subscriber: arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

Expose these as variables as that's what the standard calls them (and D131175 <https://reviews.llvm.org/D131175>).

To make this work, we also fix a bug in SelectionTree: PredefinedExpr has
an implicit/invisible StringLiteral, and SelectionTree should not traverse
implicit things.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132135

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/Selection.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp
  clang-tools-extra/clangd/unittests/SelectionTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132135.453650.patch
Type: text/x-patch
Size: 4594 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220818/25c9fb8b/attachment-0001.bin>


More information about the cfe-commits mailing list