[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

[Jeffrey Byrnes via Phabricator via cfe-commits]

jrbyrnes added a comment.

Hey Austin --

Just have a small question about the purpose of shouldApplyStrategy -- other than that, LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:758
+
+  bool shouldApplyStrategy(ScheduleDAGInstrs *DAG) override { return true; }
+
----------------
Is the plan to use heuristics on top of the builtin at some point? Not sure I understand this.


================
Comment at: llvm/lib/Target/AMDGPU/SIPostRABundler.cpp:135
+    // Don't cluster with IGLP instructions.
+    bool HasIGLPInstrs =
+        std::any_of(MBB.instr_begin(), MBB.instr_end(), [](MachineInstr &MI) {
----------------
Maybe not in this patch due to time constraints, but perhaps in future work we can extract checking for IGLP_OPT / SCHED_GROUP_BARRIER to an analysis patch so we don't need to keep checking for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132079/new/

https://reviews.llvm.org/D132079