[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

[Vaibhav Yenamandra via Phabricator via cfe-commits]

vaibhav.y updated this revision to Diff 453427.
vaibhav.y edited the summary of this revision.
vaibhav.y added a comment.

Address review comments:

- Drop include line that added `llvm/Support/ErrorHandling.h`
- Use `llvm::Optional::value_or(...)` instead of bare conditional
- Add `SarifResultLevel::None` type for encoding Remark-like diagnostics.
  - Support for these is not yet complete since it requires a custom result kind (this currently defaults to "fail", thus omitted)
  - Add a comment explaining how diagnostic levels are typically mapped to sarif result levels


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131084/new/

https://reviews.llvm.org/D131084

Files:
  clang/include/clang/Basic/Sarif.h
  clang/lib/Basic/Sarif.cpp
  clang/unittests/Basic/SarifTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131084.453427.patch
Type: text/x-patch
Size: 24343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220817/f4b27875/attachment-0001.bin>