[PATCH] D132031: Do not evaluate dependent immediate invocations

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thank you, this LGTM, though I did have a testing question. Also, please be sure to add a release note for the fix.



================
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:665
+Bar<int> f;
+Bar<float> g;
+} // namespace issue_55601
----------------
Do you think it's worth it to add a test case like:
```
struct derp {
  derp(int); // Can't be used in a constant expression

  consteval operator int() const { return 5; }
};

Bar<derp> d; // Error
```
to demonstrate that we evaluated properly at instantiation time, or do you think existing coverage already demonstrates this well enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132031/new/

https://reviews.llvm.org/D132031