[PATCH] D128981: [C++20][Modules] Implement include translation.

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 16 23:38:30 PDT 2022


jansvoboda11 added a comment.

Hi @iains, upstream Clang crashes on the attached test case due to an assertion failure. Git bisect pointed me to this commit. Can you please take a look? Previously, the test would result in a warning of incomplete umbrella header.

  // RUN: rm -rf %t && mkdir %t
  // RUN: split-file %s %t
  
  //--- frameworks/FW.framework/Modules/module.modulemap
  framework module FW {
    umbrella header "FW.h"
    module * { export * }
  }
  //--- frameworks/FW.framework/Headers/FW.h
  #include "One.h"
  //--- frameworks/FW.framework/Headers/One.h
  //--- frameworks/FW.framework/Headers/Two.h
  
  //--- module.modulemap
  module Mod { header "Mod.h" }
  //--- Mod.h
  #include "FW/Two.h"
  //--- from_module.m
  #include "Mod.h"
  
  // RUN: %clang -fmodules -fmodules-cache-path=%t/cache -iframework %t/frameworks -c %t/from_module.m -o %t/from_module.o


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128981/new/

https://reviews.llvm.org/D128981



More information about the cfe-commits mailing list