[PATCH] D130510: Missing tautological compare warnings due to unary operators

[Richard Trieu via Phabricator via cfe-commits]

rtrieu added a comment.

This patch has been moving back and forth between `IsIntegerLiteralConstantExpr` and `getIntegerLiteralSubexpressionValue`.  The first function is preexisting and the second one is a new function.  The final patch seems to settle on using just `getIntegerLiteralSubexpressionValue`.  Can you explain why the existing function does not meet your needs?  It wasn't clear from the update messages why you went that way.

Besides that, there is added support for multiple unary operators, but only minus is tested.  Each one should have at least a positive and a negative test to show it is supported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130510/new/

https://reviews.llvm.org/D130510