[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 16 12:37:54 PDT 2022


hokein added a comment.

New data on the patch:

| file                 | ambiguous nodes | forest size      | glrParse performance |
| SemaCodeComplete.cpp | 11k -> 5.7K     | 10.4MB -> 7.9MB  | 7.1MB/s -> 9.98MB/s  |
| AST.cpp              | 1.3k -> 0.73K   | 0.99MB -> 0.77MB | 6.7MB/s -> 8.4MB/s   |
|



================
Comment at: clang-tools-extra/pseudo/lib/cxx/cxx.bnf:39
 namespace-name := IDENTIFIER
-namespace-name := namespace-alias
-namespace-alias := IDENTIFIER
 class-name := IDENTIFIER
 class-name := simple-template-id
----------------
this can be removed as well, but the `class-head-name` rule uses it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130747/new/

https://reviews.llvm.org/D130747



More information about the cfe-commits mailing list