[PATCH] D131934: [clang][deps] Compute command-lines for dependencies immediately

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 16 11:52:53 PDT 2022


benlangmuir marked 2 inline comments as done.
benlangmuir added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:403
+
+static std::string getModuleCachePath(ArrayRef<std::string> Args) {
+  for (StringRef Arg : llvm::reverse(Args)) {
----------------
jansvoboda11 wrote:
> Can you split this into separate patch?
This is hard because we don't have the association between input command-line and module dependencies in the previous code.  Per our offline discussion I've mentioned this in the commit message instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131934/new/

https://reviews.llvm.org/D131934



More information about the cfe-commits mailing list