[PATCH] D113107: Support of expression granularity for _Float16.

[Zahira Ammarguellat via Phabricator via cfe-commits]

zahiraam added a comment.

I think I introduced a bug when replacing the VisitUnaryMinus/Plus/Imag/Real with VisitMinus/Plus/Imag/Real. Now this simple test case is failing in the non-promotion path (with the +avx512fp16).

_Float16 _Complex MinusOp_c_c(_Float16 c) {

  return -c;

}

error: cannot compile this scalar expression yet

  return -c;
         ^~

1 error generated.

The way I implemented it is that I have added the HANDLE_UNOP macro but I think that's wrong. I think I need to keep the VisitUnary* methods and fork out of them in the promotion path!  Same for both Scalar and Complex Exprs. Your thoughts? 
Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113107/new/

https://reviews.llvm.org/D113107