[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

Adrian Vogelsgesang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 16 01:27:45 PDT 2022


avogelsgesang added a comment.

looks good to me on a high-level, but I don't know clang well enough to confidently approve this change



================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:1107
+
+  // Corotuines will get splitted into pieces. The GNU address of label
+  // extension wouldn't be meaningful in coroutines.
----------------
Corotuines -> Coroutines


================
Comment at: clang/test/SemaCXX/addr-label-in-coroutines.cpp:5
+
+struct Allocator {};
+
----------------
unused


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131938/new/

https://reviews.llvm.org/D131938



More information about the cfe-commits mailing list