[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspiredfrom sollve

[Saiyedul Islam via Phabricator via cfe-commits]

saiislam added a comment.

In D131763#3719323 <https://reviews.llvm.org/D131763#3719323>, @jdoerfert wrote:

> In D131763#3719140 <https://reviews.llvm.org/D131763#3719140>, @saiislam wrote:
>
>> In D131763#3719132 <https://reviews.llvm.org/D131763#3719132>, @jdoerfert wrote:
>>
>>> This doesn't actually test much, only once case/compilation is covered. In the second function nothing specific to LLVM as impl is checked.
>>
>> The second function, is the only place in llvm-project where vendor(llvm) is being tested for a non-error test.
>
> Really?
>
>   ag 'vendor\(llvm\)' clang/test/OpenMP --files-with-matches                                                                                                                                                                
>   
>   clang/test/OpenMP/begin_declare_variant_messages.c
>   clang/test/OpenMP/begin_declare_variant_using_messages.cpp
>   clang/test/OpenMP/declare_variant_ast_print.c
>   clang/test/OpenMP/declare_variant_ast_print.cpp
>   clang/test/OpenMP/declare_variant_implementation_vendor_codegen.cpp
>   clang/test/OpenMP/declare_variant_messages.cpp
>   clang/test/OpenMP/declare_variant_mixed_codegen.cpp
>   clang/test/OpenMP/metadirective_ast_print.c
>   clang/test/OpenMP/metadirective_implementation_codegen.c
>   clang/test/OpenMP/nvptx_declare_variant_implementation_vendor_codegen.cpp
>   clang/test/OpenMP/declare_variant_messages.c
>   clang/test/OpenMP/metadirective_empty.cpp
>   clang/test/OpenMP/metadirective_implementation_codegen.cpp
>
> That said, the above function still doesn't test anything wrt. llvm as impl anyway. We could just as well match amd or nvidia and the check lines still match just fine.

My mistake. You are right about more tests being present. I searched in the wrong branch locally :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131763/new/

https://reviews.llvm.org/D131763