[PATCH] D131933: DebugInfo: Remove auto return type representation support

[David Blaikie via Phabricator via cfe-commits]

dblaikie created this revision.
dblaikie added reviewers: aprantl, probinson, shafik, awpandey.
Herald added a project: All.
dblaikie requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Seems this complicated lldb sufficiently for some cases that it hasn't
been worth supporting/fixing there - and it so far hasn't provided any
new use cases/value for debug info consumers, so let's remove it until
someone has a use case for it.

(side note: the original implementation of this still had a bug (I
should've caught it in review) that we still didn't produce
auto-returning function declarations in types where the function wasn't
instantiatied (that requires a fix to remove the `if
getContainedAutoType` condition in
`CGDebugInfo::CollectCXXMemberFunctions` - without that, auto returning
functions were still being handled the same as member function templates
and special member functions - never added to the member list, only
attached to the type via the declaration chain from the definition)

Further discussion about this in D123319 <https://reviews.llvm.org/D123319>

This reverts commit 5ff992bca208a0e37ca6338fc735aec6aa848b72 <https://reviews.llvm.org/rG5ff992bca208a0e37ca6338fc735aec6aa848b72>: [DEBUG-INFO] Change how we handle auto return types for lambda operator() to be consistent with gcc

This reverts commit c83602fdf51b2692e3bacb06bf861f20f74e987f <https://reviews.llvm.org/rGc83602fdf51b2692e3bacb06bf861f20f74e987f>: [DWARF5][clang]: Added support for DebugInfo generation for auto return type for C++ member functions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131933

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/CodeGen/CGDebugInfo.h
  clang/test/CodeGenCXX/debug-info-auto-return.cpp
  clang/test/CodeGenCXX/no_auto_return_lambda.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131933.452856.patch
Type: text/x-patch
Size: 8074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220816/e5b5c5e7/attachment.bin>