[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 15 09:15:36 PDT 2022
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:100
+ "%select{binary|unary}0 bitwise operator")
+ << IsUnary << OperatorLoc;
}
----------------
We still need the source range of the operand
```
[build] Value <<= diagTest(1, 2, 3);
[build] ~~~ ^
```
Vs
```
[build] Value <<= diagTest(1, 2, 3);
[build] ~~~ ^~~~~~~~~~~~~~~~~
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131678/new/
https://reviews.llvm.org/D131678
More information about the cfe-commits
mailing list