[PATCH] D131891: [clang][dataflow] Debug string for value kinds.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 15 08:24:37 PDT 2022


xazax.hun added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:34
 
+std::string debugString(Value::Kind Kind) {
+  switch (Kind) {
----------------
I think all of these `debugString` functions could return a `llvm::StringRef` or an `std::string_view`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131891/new/

https://reviews.llvm.org/D131891



More information about the cfe-commits mailing list