[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

[Alexander Malkov via Phabricator via cfe-commits]

alexiprof added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2798-2799
 def fsyntax_only : Flag<["-"], "fsyntax-only">,
-  Flags<[NoXarchOption,CoreOption,CC1Option,FC1Option]>, Group<Action_Group>;
+  Flags<[NoXarchOption,CoreOption,CC1Option,FC1Option,FlangOption]>, Group<Action_Group>,
+  HelpText<"Syntax-check only">;
 def ftabstop_EQ : Joined<["-"], "ftabstop=">, Group<f_Group>;
----------------
awarzynski wrote:
> Note that:
> 
> ```
> $ gcc --help=common | grep syntax
>   -fsyntax-only               Check for syntax errors, then stop.
> ```
> 
> and (from Clang [[ https://github.com/llvm/llvm-project/blob/main/clang/docs/CommandGuide/clang.rst | docs ]]
> >  Run the preprocessor, parser and type checking stages.
> 
> For consistency sake, I would replace "Syntax-check only"" with "Run the preprocessor, parser and type checking stages.". Technically, there's no separate preprocessor in Flang, but that's IMO tangential to this.
Yes, i am replace text


================
Comment at: clang/include/clang/Driver/Options.td:3213-3214
 def headerpad__max__install__names : Joined<["-"], "headerpad_max_install_names">;
-def help : Flag<["-", "--"], "help">, Flags<[CC1Option,CC1AsOption, FC1Option,
-    FlangOption]>, HelpText<"Display available options">,
+def help : Flag<["-", "--"], "help">, Flags<[CC1Option,CC1AsOption,FC1Option,FlangOption]>,
+  HelpText<"Display available options">,
     MarshallingInfoFlag<FrontendOpts<"ShowHelp">>;
----------------
awarzynski wrote:
> Unrelated change?
yes, mini fix format.
If it bothers you, I can remove it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131808/new/

https://reviews.llvm.org/D131808