[PATCH] D131268: [HLSL] Generate buffer subscript operators

Xiang Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 12 17:11:33 PDT 2022


python3kgae added inline comments.


================
Comment at: clang/test/CodeGenHLSL/buffer-array-operator.hlsl:3
+
+const RWBuffer<float> In;
+RWBuffer<float> Out;
----------------
beanz wrote:
> python3kgae wrote:
> > Why add const instead of using Buffer directly?
> > 
> Making this const forces the const methods to be used. It is just to drive the correct validation and code generation.
So maybe we don't need Buffer at all, just use const RWBuffer for read-only usage?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131268/new/

https://reviews.llvm.org/D131268



More information about the cfe-commits mailing list