[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:98
+  if (HLSLNumThreadsAttr *NumThreadsAttr = FD->getAttr<HLSLNumThreadsAttr>()) {
+    const StringRef NumThreadsKindStr = "dx.numthreads";
+    std::string NumThreadsStr;
----------------
This isn't DirectX-specific, so we should name it `hlsl`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131799/new/

https://reviews.llvm.org/D131799