[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

LLVM switched to C++17 recently. I am not sure whether this means `std::optional` is preferred over `llvm::Optional`.



================
Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3902
               },
-              {/*.ApplyBuiltinTransfer=*/true,
-               /*.BuiltinTransferOptions=*/{/*.ContextSensitive=*/false}});
+              {TransferOptions{llvm::Optional<ContextSensitiveOptions>()}});
 }
----------------
I think `llvm::None` is a more concise way to create an empty optional (akin to `std::nullopt`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131779/new/

https://reviews.llvm.org/D131779