[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 18:34:28 PDT 2022


jrtc27 added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/riscv-abi.cpp:1
 // RUN: %clang_cc1 -triple riscv32 -emit-llvm -x c++ %s -o - \
 // RUN:   | FileCheck -check-prefixes=ILP32,ILP32-ILP32F,ILP32-ILP32F-ILP32D %s
----------------
Not sure why you need -x c++ when it's a .cpp, that should be the default.

Also C++ tests belong in CodeGenCXX surely? Though I do see a lot of .cpp files in CodeGen...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131677/new/

https://reviews.llvm.org/D131677



More information about the cfe-commits mailing list