[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 14:51:51 PDT 2022


shafik added a comment.

Ok it looks like this is a bit more subtle, I broke the llvm-test-suite file `paq8p.cpp` again. We need both conditions to be true `Info.EvalMode == EvalInfo::EM_ConstantExpression && Info.InConstantContext`. We need to be in a context that requires a constant value but also in a constant expression context.

We are doing a little bit of an odd thing here and so this is a bit unique. I am doing a quick `check-clang` and will patch this up as long as that passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131704/new/

https://reviews.llvm.org/D131704



More information about the cfe-commits mailing list