[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 13:04:14 PDT 2022


ahatanak added inline comments.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:702
   set(BUILTIN_CFLAGS "")
+  add_security_warnings(BUILTIN_CFLAGS -1)
 
----------------
I'm passing -1 here since I wasn't sure whether the definition of `eprintf` is needed on non-apple platforms. If it isn't needed. we can pass 0 instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131714/new/

https://reviews.llvm.org/D131714



More information about the cfe-commits mailing list