[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 10:44:51 PDT 2022


aaron.ballman added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402
+    RetType = CGM.getContext().getLValueReferenceType(RetType);
+  assert(!RetType.isNull() && "Not certain of the constant expression's type");
+
----------------
efriedma wrote:
> Not sure the assertion is useful; RetType is obviously non-null in the current version.
Fair enough, I removed it when landing the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131194/new/

https://reviews.llvm.org/D131194



More information about the cfe-commits mailing list