[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

[Eli Friedman via Phabricator via cfe-commits]

efriedma accepted this revision as: efriedma.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402
+    RetType = CGM.getContext().getLValueReferenceType(RetType);
+  assert(!RetType.isNull() && "Not certain of the constant expression's type");
+
----------------
Not sure the assertion is useful; RetType is obviously non-null in the current version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131194/new/

https://reviews.llvm.org/D131194