[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 08:20:09 PDT 2022


ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9073
     SmallVector<MapData, 4> DeclComponentLists;
+    if (DevPointersMap.count(VD)) {
+      // For member fields list in is_device_ptr, store it in
----------------
If VD is nullptr, why do we need this check?


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9080
+          DeclComponentLists.emplace_back(MCL, OMPC_MAP_to,
+                                          OMPC_MAP_MODIFIER_unknown, true,
+                                          nullptr, nullptr);
----------------
comment with the name of parameter, associated with `true` value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129608/new/

https://reviews.llvm.org/D129608



More information about the cfe-commits mailing list