[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

Vladimir Plyashkun via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 07:55:59 PDT 2022


vladimir.plyashkun added a comment.

Hi @carlosgalvezp
Yes, sorry, maybe screenshot and example from issue in our bugtracker is not the best one. 
You can check it on this sample <https://godbolt.org/z/hxMW16vxr> from clang-tidy tests:
The "hicpp-signed-bitwise" will point to

  URes = UValue & -1;
              ^

instead of -1, which looks confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131678/new/

https://reviews.llvm.org/D131678



More information about the cfe-commits mailing list