[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

Eric Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 07:52:36 PDT 2022


li.zhe.hua marked an inline comment as done.
li.zhe.hua added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:119
+  std::unique_ptr<ASTUnit> AST =
+      tooling::buildASTFromCodeWithArgs("int x = 0;", {"-std=c++11"});
+  HasWidenAnalysis Analysis(AST->getASTContext(),
----------------
ymandel wrote:
> nit: why c++11 (vs something later)?
Consistency with `runAnalysis` defined above. FWIW, I don't think `int x = 0;` is materially different in any standard, and all I really want out of this is an `ASTContext` to pass to `TypeErasedDataflowAnalysis` to satisfy its constructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131645/new/

https://reviews.llvm.org/D131645



More information about the cfe-commits mailing list