[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 06:52:36 PDT 2022


dongjunduo added a comment.

In D131469#3715929 <https://reviews.llvm.org/D131469#3715929>, @jamieschmeiser wrote:

> You should not have debugging information in code that is up for review.  If this is debugging information that you plan to leave in for future purposes (which I doubt is the case here), you need to protect it so that it isn't active unless some option is set.  For example, see LLVM_DEBUG code that lives in various opt routines.

Got it. I want to use this unnecessary `print` to find why some tests passed in local but failed in CI. They will be removed soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469



More information about the cfe-commits mailing list