[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Jamie Schmeiser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 06:02:54 PDT 2022


jamieschmeiser added a comment.

You should not have debugging information in code that is up for review.  If this is debugging information that you plan to leave in for future purposes (which I doubt is the case here), you need to protect it so that it isn't active unless some option is set.  For example, see LLVM_DEBUG code that lives in various opt routines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469



More information about the cfe-commits mailing list