[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

Brahmajit via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 00:52:26 PDT 2022


listout marked an inline comment as done.
listout added a comment.

@barannikov88 made some changes. What do you think?



================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49
 
+  std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu";
+
----------------
barannikov88 wrote:
> * `!isMusl()` does not mean it is "gnu".
> * Why don't just use `Triple::getEnvironmentTypeName`?
> 
Sure, I'll change the patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131563/new/

https://reviews.llvm.org/D131563



More information about the cfe-commits mailing list