[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

Sergei Barannikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 14:51:50 PDT 2022


barannikov88 added a comment.

The diff seems to be restricted to few lines. It should include the full context.



================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49
 
+  std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu";
+
----------------
* `!isMusl()` does not mean it is "gnu".
* Why don't just use `Triple::getEnvironmentTypeName`?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131563/new/

https://reviews.llvm.org/D131563



More information about the cfe-commits mailing list