[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 10:03:31 PDT 2022


ilya-biryukov added a comment.

Could you please add a test with a compilation database that models the blocking behavior, attempts cancellation and ensures no diagnostics are produced?
I also suggest adding a callback similar to `Callbacks.onFailedAST`, which could be used for testing this behavior.
The test should also check that subsequent updates and reads get resolved properly.

We don't have an actual implementation for the client code that relies on this in-tree, but the unit test will help to ensure we don't break this contract.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131569/new/

https://reviews.llvm.org/D131569



More information about the cfe-commits mailing list