[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

[Caroline via Phabricator via cfe-commits]

CarolineConcatto added a comment.

> Are you intending to AutoUpgrade the existing intrinsics in IR?

@RKSimon  
AFAIK we want to remove them altogether. 
It is not expected that external projects depend on these intrinsics.
It is a legacy intrinsic that was introduced before we had vector.extract and vector.insert



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9091
+
+Value *CodeGenFunction::EmmitSVEGetTuples(const SVETypeFlags &TypeFlags,
+                                          llvm::Type *Ty,
----------------
sdesmalen wrote:
> nit: Can this function be merged with the function above, you could pass `bool IsInsert`?
I did what you suggested. Don't know if it is much better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131547/new/

https://reviews.llvm.org/D131547