[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

YingChi Long via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 03:38:20 PDT 2022


inclyc added a comment.

@aaron.ballman @shafik  (Help wanted). These type traits will not cause clang to crash if current patch applied, but the `bool x` in that test case will evaluate to `false`.  I think the problem behind the github issue is that we don't check the number of arguments for builtin type trait like `__is_constructible`

I wanted to ask what is our expected behavior for this, give an error like using `std::is_constructible` or just consider `__is_constructible` should always have a bool value? Should we report a warning but compile translation unit, or report an error and terminate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131423/new/

https://reviews.llvm.org/D131423



More information about the cfe-commits mailing list