[PATCH] D131298: [clang-doc] Read docstrings for record members
Brett Wilson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 9 16:16:30 PDT 2022
brettw updated this revision to Diff 451299.
brettw marked an inline comment as done.
brettw added a comment.
I updated the comment test that's not currently working with a TODO.
There are some open questions in the code review about some bigger questions about this tool. Since this has been virtually abandoned for several years, I don't think anybody knows these answers and we're not going to figure out everything for this patch.
I think this patch makes things incrementally better and I'd like to land something soon so I can work on the next missing feature. I think over time we can build up knowledge about this tool and make it better on a wider scale. Can you please talk another look?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131298/new/
https://reviews.llvm.org/D131298
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeWriter.cpp
clang-tools-extra/clang-doc/Representation.h
clang-tools-extra/clang-doc/Serialize.cpp
clang-tools-extra/clang-doc/YAMLGenerator.cpp
clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
clang-tools-extra/unittests/clang-doc/SerializeTest.cpp
clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131298.451299.patch
Type: text/x-patch
Size: 11447 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220809/7da8ab70/attachment.bin>
More information about the cfe-commits
mailing list