[PATCH] D130516: [llvm] compression classes

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 9 14:38:15 PDT 2022


MaskRay added a comment.

I have only taken very brief look at the new version. Having an enum class `CompressionKind` with a parallel `CompressionAlgorithm` seems redundant.
`friend CompressionAlgorithm *CompressionKind::operator->() const;` looks magical.

I hope that someone insisting on object-oriented design can put up a version with less boilerplate to compete with D130506 <https://reviews.llvm.org/D130506>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130516/new/

https://reviews.llvm.org/D130516



More information about the cfe-commits mailing list